mdedetrich opened a new issue, #1205: URL: https://github.com/apache/pekko/issues/1205
In https://github.com/apache/incubator-pekko/pull/252 I made it so that we can set `SupervisionStrategy` rather than using `SubStreamCancelStrategy`. It turns out there is an existing test which was written as pending (so its currently disabled) to test this exact `SupervisionStrategy` functionality (specifically `SupervisionStrategy.resumingDecider` when an exception is thrown) when its adding in the future (which is now) i.e. https://github.com/apache/incubator-pekko/blob/c44c0b7cbdab11d85176cfe062288fdcba16c56a/stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowSplitAfterSpec.scala#L213-L262 When I try to enable the test by removing `pending` so the test runs it actually does not pass which means that the `SupervisionStrategy.resumingDecider` is not properly catching and suppressing the exception as its meant to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
