laglangyue commented on code in PR #575:
URL: https://github.com/apache/pekko-http/pull/575#discussion_r1677718178
##########
http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/HeaderParser.scala:
##########
@@ -86,8 +86,9 @@ private[http] class HeaderParser(
def failure(error: Throwable): HeaderParser.Failure =
HeaderParser.Failure {
error match {
- case IllegalUriException(info) => info
- case NonFatal(e) =>
ErrorInfo.fromCompoundString(e.getMessage)
+ case IllegalUriException(info) => info
+ case NonFatal(e) if e.getMessage == null =>
ErrorInfo.fromCompoundString(e.toString)
Review Comment:
`e.getMessage eq null` ? I don't think it is good. `eq` is used to replace
the equals method, and when compared to null, it is usually to use `==`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
