raboof commented on code in PR #354:
URL: https://github.com/apache/pekko-grpc/pull/354#discussion_r1713380534
##########
build.sbt:
##########
@@ -71,6 +71,10 @@ lazy val codegen = Project(id = "codegen", base =
file("codegen"))
(assembly / mainClass) := Some("org.apache.pekko.grpc.gen.Main"),
(assembly / assemblyOption) := (assembly /
assemblyOption).value.withPrependShellScript(
Some(sbtassembly.AssemblyPlugin.defaultUniversalScript(shebang = true))),
+ (assembly / assemblyMergeStrategy) := {
+ case PathList("META-INF", _*) => MergeStrategy.discard
+ case _ => MergeStrategy.first
Review Comment:
Wouldn't it be safer to use `MergeStrategy.deduplicate`?
(https://github.com/sbt/sbt-assembly?tab=readme-ov-file#merge-strategy, also
https://arxiv.org/abs/2407.18760 though I'm more concerned about
correctness/reproducibility than with security in this case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
