Roiocam commented on PR #293: URL: https://github.com/apache/pekko-management/pull/293#issuecomment-2317745127
> > if i remember correctly, Kubernetes recommend TCP probe rather than HTTP probe for startup probe, because efficiency reason. > > In theory, we could support TCP based checks for readiness and liveness too. Maybe we could add a separate enhancement (a later PR) where we support configs like 'startup-check-type', 'readiness-check-type' and 'liveness-check-type' (defaulting to 'http') to maintain compatibility. I think `pekko-management` was probe destination provider, this PR provide HTTP endpoint as startup check(for startup probe use). I don't deep dive into health checks yet, but i think it just expose HTTP endpoint and then response `ok` to requestor, what's difference between to startup checks? i don't think it has. anyway, i will take time to deep divde into it immdiately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
