Roiocam commented on code in PR #1485:
URL: https://github.com/apache/pekko/pull/1485#discussion_r1764789225
##########
actor/src/main/scala/org/apache/pekko/actor/dungeon/Dispatch.scala:
##########
@@ -159,7 +159,7 @@ private[pekko] trait Dispatch { this: ActorCell =>
catch handleException
// ➡➡➡ NEVER SEND THE SAME SYSTEM MESSAGE OBJECT TO TWO ACTORS ⬅⬅⬅
- final def stop(): Unit =
+ @noinline final def stop(): Unit =
Review Comment:
Thanks for the clarification. @jrudolph
##########
actor/src/main/scala/org/apache/pekko/actor/dungeon/Dispatch.scala:
##########
@@ -159,7 +159,7 @@ private[pekko] trait Dispatch { this: ActorCell =>
catch handleException
// ➡➡➡ NEVER SEND THE SAME SYSTEM MESSAGE OBJECT TO TWO ACTORS ⬅⬅⬅
- final def stop(): Unit =
+ @noinline final def stop(): Unit =
Review Comment:
I am not sure this PR can be resolve the kamon issue, because [Kamon
Instruementation](https://github.com/kamon-io/Kamon/blob/master/instrumentation/kamon-pekko/src/main/scala/kamon/instrumentation/pekko/instrumentations/DispatcherInstrumentation.scala)
seem like didn't advise/intercept this method.
the stack trace of the original issue post shows that the
`DispatcherPrerequisites` weren't assigned correctly.
Is it probably caused by this inline?
https://github.com/apache/pekko/blob/0f1db5301ed87fea39ab331b5bce88022ccb54da/actor/src/main/scala-2.13/org/apache/pekko/compat/PartialFunction.scala#L28-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
