pjfanning commented on code in PR #827:
URL: https://github.com/apache/pekko-connectors/pull/827#discussion_r1774959185
##########
aws-spi-pekko-http/src/main/scala/org/apache/pekko/stream/connectors/awsspi/PekkoHttpClient.scala:
##########
@@ -151,18 +153,42 @@ object PekkoHttpClient {
else throw new RuntimeException(s"Could not parse custom content type
'$contentTypeStr'.")
}
+ // based on NettyNioAsyncHttpClient and ApacheHttpClient
Review Comment:
If I read the links correctly, they just highlight that the constants exist.
One issue in the ASF is that we are careful about updating our LICENSE file
when we borrow 3rd party code so people look for 'based on' in our code to make
sure that noone has copied 3rd party code.
It might be best to remove the links in this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
