pjfanning commented on code in PR #12:
URL:
https://github.com/apache/pekko-persistence-dynamodb/pull/12#discussion_r1804489279
##########
src/main/scala/org/apache/pekko/persistence/dynamodb/query/scaladsl/DynamoDBCurrentPersistenceIdsQuery.scala:
##########
@@ -69,7 +69,14 @@ trait CreatePersistenceIdsIndex {
object CreatePersistenceIdsIndex {
- /** required by
[[DynamoDBCurrentPersistenceIdsQuery.currentPersistenceIdsByPageQuery]] */
+ /**
+ * required by
[[DynamoDBCurrentPersistenceIdsQuery.currentPersistenceIdsByPageQuery]]
+ *
+ * When requesting snapshots by timestamp, Select ALL_ATTRIBUTES is used.
Thus, a duplicate of
+ * the payload doesn't need to be stored in the index, which is more space
efficient.
+ * This allows to make the choice between time and space efficiency by
selecting the projection
+ * strategy for the created index.
Review Comment:
@spangaer could you make a small adjustment to this comment to say that the
ALL_ATTRIBUTES change was only brought in v1.1.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
