ptrdom commented on issue #158: URL: https://github.com/apache/pekko-persistence-r2dbc/issues/158#issuecomment-2427565736
@pjfanning Yes, planning to pick this up soon. Your suggested approach makes total sense. Would it be beneficial to have MySQL support in a separate repository? I remember how when working on [endpoints4s](https://github.com/endpoints4s/endpoints4s) we started breaking up the repository apart, putting different implementations in separate repositories to ease up the burden of maintaining every single implementation once we change something in the core. I guess that does not seem critical when number of implementations is small, but as the number grows it does become an increasing burden on maintainers. Although we could say that databases like Postgres and MySQL are the core of pekko-persistence-r2dbc that we do want to keep most up to date, so splitting to a separate repository would just complicate that. Even if we stay in a single repository for this work, it would probably make sense to have a sbt module per implementation, not sticking support of every database into `core` sbt module, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
