ptrdom commented on code in PR #170:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/170#discussion_r1826957141
##########
.github/workflows/build-test.yml:
##########
@@ -130,7 +130,51 @@ jobs:
docker exec -i yb-tserver-n1 /home/yugabyte/bin/ysqlsh -h
yb-tserver-n1 -t < ddl-scripts/create_tables_yugabyte.sql
- name: test
- run: sbt -Dpekko.persistence.r2dbc.dialect=yugabyte
-Dpekko.projection.r2dbc.dialect=yugabyte ++${{ matrix.SCALA_VERSION }} test
+ run: sbt -Dpekko.persistence.r2dbc.dialect=yugabyte
-Dpekko.projection.r2dbc.dialect=yugabyte ++${{ matrix.SCALA_VERSION }}
yugabyte/test
+
+ test-mysql:
+ name: Run test with MySQL
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ SCALA_VERSION: [ 2.12, 2.13, 3.3 ]
+ JAVA_VERSION: [ 8, 11 ]
+ if: github.repository == 'apache/pekko-persistence-r2dbc'
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ fetch-tags: true
+
+ - name: Checkout GitHub merge
+ if: github.event.pull_request
+ run: |-
+ git fetch origin pull/${{ github.event.pull_request.number
}}/merge:scratch
+ git checkout scratch
+
+ - name: Setup Java ${{ matrix.JAVA_VERSION }}
+ uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: ${{ matrix.JAVA_VERSION }}
+
+ - name: Install sbt
+ uses: sbt/setup-sbt@v1
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6
+
+ - name: Enable jvm-opts
+ run: cp .jvmopts-ci .jvmopts
+
+ - name: Start DB
+ run: |-
+ docker compose -f docker/docker-compose-mysql.yml up -d --wait
+ docker exec -i docker-mysql-db-1 --user=root --password=root
--database=mysql < ddl-scripts/create_tables_mysql.sql
Review Comment:
Basic mistake is that the MySQL CLI command is incomplete. More problematic
part is that MySQL seems to take longer to boot, so a very generous sleep would
be needed to make sure CI does not fail. Good idea would be to try and add a
proper health check to docker compose for MySQL, so that `--wait` actually
waits until the database is usable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
