pjfanning commented on PR #170: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/170#issuecomment-2466234279
> I do not understand the fixation on projections module only, because this project is about `core` (journal) and `projection` implementation, so any new database implementation in seperate sbt modules would mean two new modules to the project - use of journal does not imply the need to use projections, but projections without journal are realistically meaningless. > > We can surely merge MySQL implementation back to `core` and `projection` modules, though I did ask for approval before working on separate modules and did spend additional effort to make separate modules work while keeping backwards compatibility on existing modules, so a pivot at this point certainly is not encouraging for me as a contributor. So can you confirm specific implementation parameters for me that would end up with a merged PR that has MySQL support? I appreciate that there has been a pivot. This is a large PR and had to review. There is a strong argument that the existing structure of this repo and its jars makes it hard to add support for extra DB implementations. I have never used pekko-projections or akka-projections. I am just a volunteer. There are no other volunteers currently showing much interest in pekko-projections. Now that I know more about the code, I think it is better to expand the existing modules than to introduce new ones. I would prefer if we start with core module (one PR) and later do a separate PR for the projection module (a 2nd PR). If you want to discontinue work on this, that is understood. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
