pjfanning commented on issue #411: URL: https://github.com/apache/pekko-grpc/issues/411#issuecomment-2473046820
> > I am not sure if they are needed > > They are used in https://github.com/apache/pekko-grpc/blob/main/gradle-plugin/src/main/groovy/org/apache/pekko/grpc/gradle/PekkoGrpcPlugin.groovy#L108 . > > > The assembly jar bundles lots of scala-library, io.grpc, guava, protobuf, checkerframework classes but the only LICENSE and NOTICE in the jar are copied from the scala-library. > > Thanks @raboof for the pointer. The jar plain pekko-grpc-codegen jar is published with a pom file that lists the dependencies. https://repository.apache.org/content/groups/staging/org/apache/pekko/pekko-grpc-codegen_2.13/1.1.1/pekko-grpc-codegen_2.13-1.1.1.pom Maybe, we could get away with changing PekkoGrpcPlugin.groovy to use the plain jar and rely on Gradle to fetch the dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
