mdedetrich commented on code in PR #630: URL: https://github.com/apache/pekko-http/pull/630#discussion_r1843729039
########## http-core/src/main/scala/org/apache/pekko/http/javadsl/model/ContentType.scala: ########## @@ -61,4 +61,9 @@ trait ContentType { * Returns the charset if this ContentType is non-binary. */ def getCharsetOption: Optional[HttpCharset] + + /** + * Returns the string representation of this ContentType + */ Review Comment: I would add 1.2.0 because its technically a new method in order to follow semver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org