pjfanning commented on code in PR #630: URL: https://github.com/apache/pekko-http/pull/630#discussion_r1844988342
########## http-core/src/main/scala/org/apache/pekko/http/javadsl/model/ContentType.scala: ########## @@ -61,4 +61,10 @@ trait ContentType { * Returns the charset if this ContentType is non-binary. */ def getCharsetOption: Optional[HttpCharset] + + /** + * Returns the string representation of this ContentType + * @since 1.2.0 + */ + def value: String } Review Comment: If leaving this as `def value = ???` is easier, I am ok with that. It seems like the Java API is already inconsistent stylistically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org