pjfanning commented on code in PR #267:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/267#discussion_r1948270542
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/query/javadsl/JdbcReadJournal.scala:
##########
@@ -32,7 +38,8 @@ class JdbcReadJournal(journal: ScalaJdbcReadJournal)
with CurrentEventsByPersistenceIdQuery
with EventsByPersistenceIdQuery
with CurrentEventsByTagQuery
- with EventsByTagQuery {
+ with EventsByTagQuery
+ with CurrentLastKnownSequenceNumberByPersistenceIdQuery {
Review Comment:
My aim would be merge this without the marker trait meaning that we could
release a version pekko-persistence-jdbc 1.1.x that supports this but without
needing a new Pekko core release. pekko-persistence 1.2.0-M2 and above could
have the marker trait and a pekko-persistence-jdbc 1.2.0(-M1) release could
rely on pekko-persistence 1.2.0-M2 and uptake the marker trait.
I haven't studied pekko-persistence-r2dbc but I presume that it too could
implement this support and in a similar timeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
