pjfanning commented on code in PR #1819: URL: https://github.com/apache/pekko/pull/1819#discussion_r2052747196
########## stream/src/main/scala/org/apache/pekko/stream/stage/GraphStage.scala: ########## @@ -1643,7 +1644,10 @@ abstract class GraphStageLogic private[stream] (val inCount: Int, val outCount: * * Typical use cases are exchanging messages between stream and substreams or invoking from external world sending * event to a stream + * + * Not for user extension */ +@DoNotInherit Review Comment: Why not let users extend and even override this trait? I have no problem with the code changes - just the doc and annotation changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
