Tomassino-ibm commented on PR #1919: URL: https://github.com/apache/pekko/pull/1919#issuecomment-3047910535
> Regarding the tailrec, the intention of writing it as tailrec was actually to maintain the original style so its easier to read and hence make sure that its behaving more correctly. While its true that the current implementation doesn't have `@tailrec`, thats because the current implementation is so simple that there aren't any loops to begin with. > > I just compared the tailrec version to the older non-tailrec version and the tailrec version is far easier simpler, so my preference would be to stick to the tailrec version (this is why I pushed for it). I think @pjfanning was referring to the original code (before this pull request) versus the pull request implementation of `onMessage` and `onCommand`: since it's possible that the new code introduces some subtle changes that might result in different outcomes in some edge cases, it's better to make it as explicit as possible that, if the configuration flag (`recurse-when-unstashing-read-only-commands`) is enabled, code works like before. Regarding the tailrec function replacing the loop, I also agree that it looks nicer and more idiomatic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
