pjfanning commented on code in PR #1968:
URL: https://github.com/apache/pekko/pull/1968#discussion_r2239820548
##########
project/Jdk9.scala:
##########
@@ -15,14 +15,11 @@ import sbt.Keys._
import sbt._
object Jdk9 extends AutoPlugin {
- import JdkOptions.notOnJdk8
import JdkOptions.JavaVersion._
- // The version 9 is special for any Java versions >= 9
- // and the version 11 is special for any Java versions >= 11
- // and the version 17 is special for any Java versions >= 17
+ // The version 17 is special for any Java versions >= 17
// and the version 21 is special for any Java versions >= 21
- private val supportedJavaLTSVersions = List("9", "11", "17", "21")
+ private val supportedJavaLTSVersions = List("17", "21")
lazy val CompileJdk9 = config("CompileJdk9").extend(Compile)
Review Comment:
I intend to follow and have noted in the PR description that this work is
still needed. I had a quick look and the build plumbing for this Jdk9 option is
surprisingly large so I was hoping to tackle it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
