mdedetrich commented on PR #1980: URL: https://github.com/apache/pekko/pull/1980#issuecomment-3146297529
> lgtm for 2.0.x, does the jmh show real boost? JVM will normally inline such calls, however the JVM only inlines up until a limit (which can be overridden but a user manually has to pass a flag into the JVM instance), see https://stackoverflow.com/questions/32503669/why-does-the-jvm-have-a-maximum-inline-depth. I have actually hit this in production, in contexts outside of akka/pekko So in summary, if we can inline calls (especially trivial ones like this one) then we should as it reduces the change that users will hit that `MaxInlineLevel` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
