pjfanning commented on PR #1995: URL: https://github.com/apache/pekko/pull/1995#issuecomment-3146484213
> > * the VarHandle still needs `--add-opens=java.base/java.lang=ALL-UNNAMED` or equivalent so I think is ok to keep the Pekko class name as pekko.util.Unsafe - and this is better for backward compatibility too because the public methods are used in other Pekko modules > > Hmm, will have to think about this because iirc one algorithm is quite a bit faster than the other and the one that is faster is the one that uses `.value` @raboof @He-Pin any comments? @mdedetrich The change keeps the code that gets the `value` byte array from the string and uses it. The only change is that I use a VarHandle to get it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
