Copilot commented on code in PR #485:
URL: https://github.com/apache/pekko-grpc/pull/485#discussion_r2252162139
##########
runtime/src/main/scala/org/apache/pekko/grpc/javadsl/package.scala:
##########
@@ -39,14 +43,16 @@ package object javadsl {
* Helper for creating Scala partial functions from [[pekko.japi.Function]]
* instances as Scala 2.11 does not know about SAMs.
*/
+ @deprecated("no longer needed since support for Scala 2.11 has been
dropped", "1.2.0")
def scalaPartialFunction[A, B](f: pekko.japi.Function[A, B]):
PartialFunction[A, B] = {
case a => f(a)
}
/**
* Helper for creating Scala anonymous partial functions from
[[pekko.japi.Function]]
- * instances as Scala 2.11 does not know about SAMs.
+ * instances.
*/
Review Comment:
The comment should be updated to explain why this function still exists
despite the others being deprecated, or it should also be deprecated if it's no
longer needed.
```suggestion
*/
@deprecated("no longer needed since support for Scala 2.11 has been
dropped", "1.2.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
