pjfanning commented on code in PR #2009:
URL: https://github.com/apache/pekko/pull/2009#discussion_r2254246873
##########
actor/src/main/scala/org/apache/pekko/dispatch/Future.scala:
##########
@@ -137,6 +137,7 @@ object Futures {
/**
* Creates an already completed CompletionStage with the specified exception
*/
+ @deprecated("Use `CompletableFuture#failedStage` instead.", since = "2.0.0")
def failedCompletionStage[T](ex: Throwable): CompletionStage[T] = {
Review Comment:
*if this is not needed any more - could we do a 1.2.x change to deprecate it
and use CompletableFuture#failedStage instead?
* the changes that affect binary compatibility would have to be for 2.x only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
