pjfanning commented on code in PR #2011:
URL: https://github.com/apache/pekko/pull/2011#discussion_r2256279905
##########
stream/src/main/scala/org/apache/pekko/stream/ActorMaterializer.scala:
##########
@@ -764,45 +522,15 @@ final class ActorMaterializerSettings @InternalApi
private (
s"$syncProcessingLimit,$fuzzingMode,$autoFusing,$ioSettings)"
}
-object IOSettings {
- @deprecated(
- "Use setting 'pekko.stream.materializer.io.tcp.write-buffer-size' or
attribute TcpAttributes.writeBufferSize instead",
- "Akka 2.6.0")
- def apply(system: ActorSystem): IOSettings =
- apply(system.settings.config.getConfig("pekko.stream.materializer.io"))
-
+@InternalApi
+private[pekko] object IOSettings {
@deprecated(
"Use setting 'pekko.stream.materializer.io.tcp.write-buffer-size' or
attribute TcpAttributes.writeBufferSize instead",
"Akka 2.6.0")
def apply(config: Config): IOSettings =
new IOSettings(
tcpWriteBufferSize = math.min(Int.MaxValue,
config.getBytes("tcp.write-buffer-size")).toInt,
coalesceWrites = config.getInt("tcp.coalesce-writes"))
Review Comment:
This method is still used. My idea is to try to get rid of the unused
methods first and then to come back later and try to remove the code that still
uses this method so that it can be removed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
