Roiocam commented on code in PR #2037:
URL: https://github.com/apache/pekko/pull/2037#discussion_r2287045428
##########
actor/src/main/scala/org/apache/pekko/actor/Scheduler.scala:
##########
@@ -303,7 +299,16 @@ trait Scheduler {
implicit
executor: ExecutionContext,
sender: ActorRef = Actor.noSender): Cancellable =
- schedule(initialDelay, interval, receiver, message)
+ schedule(
+ initialDelay,
+ interval,
+ new Runnable {
+ def run(): Unit = {
+ receiver ! message
+ if (receiver.isTerminated)
+ throw SchedulerException("timer active for terminated actor")
Review Comment:
does scheduler catch SchedulerException propertly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
