He-Pin commented on code in PR #2092:
URL: https://github.com/apache/pekko/pull/2092#discussion_r2299272806
##########
persistence/src/main/java/org/apache/pekko/persistence/journal/japi/AsyncWritePlugin.java:
##########
@@ -70,16 +70,22 @@ interface AsyncWritePlugin {
* and the max batch size is reached.
*
* <p>This call is protected with a circuit-breaker.
+ *
+ * @return a CompletionStage that will be completed when the write is done
(in Pekko 1.x, this was
+ * a Scala Future)
*/
- Future<Iterable<Optional<Exception>>>
doAsyncWriteMessages(Iterable<AtomicWrite> messages);
+ CompletionStage<Iterable<Optional<Exception>>> doAsyncWriteMessages(
+ Iterable<AtomicWrite> messages);
Review Comment:
Should this be a Java Iterable？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
