mdedetrich commented on issue #2093: URL: https://github.com/apache/pekko/issues/2093#issuecomment-3221998564
> I'm not at all sure that I like a major refactor just because a Java friendly terminate isn't implemented. Can we at least review the API on the typed ActorSystem which is different from the class ActorSystem? The diff being that terminate returns void/unit. And then users need to call getWhenTerminated() (Java) or whenTerminated() (Scala) to get a CompletionStage or Future as required. These 2 methods are on the classic ActorSystem too. > > I think we should try to still bear in mind that it is good to keep the disruption to migrating users to a minimum. The thing is its not just `.terminate` that returns a `Future`, there is also `whenTerminated`. But you are right in that I should look into the typed `ActorSystem` and see the reasoning/intent behind it returning `Void`/`Unit` (I guess they made that method blocking to make it easier to use, although if thats the case that is a not very akka/pekko like???) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
