mdedetrich commented on issue #2093: URL: https://github.com/apache/pekko/issues/2093#issuecomment-3223881554
> I'm still skeptical as well - I suspect consistently splitting ActorSystem into a javadsl and a scaladsl variant will uncover some tricky situations and we'll have to carefully consider whether these are 'worth it' - but can't hurt to give it a try. Just don't get tunnel-visioned into this experiment. I think its quite safe because in reality the only changes will be moving the `terminate` (and related methods) out of the current base `ActorSystem` class but the rest will remain the same. But yes you are right, we should try this out. > Since we're thinking 2.0.0 anyway: perhaps `ActorSystem` should implement https://docs.oracle.com/javase/8/docs/api/java/io/Closeable.html, and `terminate` should be deprecated in favor of `close` and `whenTerminated`/`getWhenTerminated`. This is a good point! If we are going to add `Unit`/`Void` based terminate like methods to make it easier, may as well do it in the idiomatic way and implement Java's closable interface rather than calling it `terminateAndAwait` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
