pjfanning commented on code in PR #2097: URL: https://github.com/apache/pekko/pull/2097#discussion_r2311959530
########## actor-tests/src/test/java-jdk21-only/org/apache/pekko/actor/UntypedStashJavaAPI.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * This file is part of the Apache Pekko project, which was derived from Akka. + */ + +/* + * Copyright (C) 2018-2022 Lightbend Inc. <https://www.lightbend.com> + */ + +package org.apache.pekko.actor; + +import org.apache.pekko.testkit.PekkoJUnitActorSystemResource; +import org.apache.pekko.testkit.TestProbe; +import org.junit.ClassRule; +import org.junit.Test; +import org.scalatestplus.junit.JUnitSuite; + +public class UntypedStashJavaAPI extends JUnitSuite { Review Comment: can this test really need Java 21+? Can we add some tests that don't need Java 21 anyway? I can understand that the tests that use the new `switch` support need Java 21+ but Stash works with all Java versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
