He-Pin commented on code in PR #2128:
URL: https://github.com/apache/pekko/pull/2128#discussion_r2315769318
##########
stream/src/main/scala/com/typesafe/sslconfig/pekko/util/PekkoLoggerBridge.scala:
##########
@@ -15,18 +15,27 @@ package com.typesafe.sslconfig.pekko.util
import org.apache.pekko
import pekko.actor.ActorSystem
+import pekko.annotation.InternalApi
import pekko.event.{ DummyClassForStringSources, EventStream }
import pekko.event.Logging._
import com.typesafe.sslconfig.util.{ LoggerFactory, NoDepsLogger }
+/**
+ * Internal Usage only. Will be removed in Pekko 2.0.0.
+ */
+@InternalApi
final class PekkoLoggerFactory(system: ActorSystem) extends LoggerFactory {
override def apply(clazz: Class[_]): NoDepsLogger = new
PekkoLoggerBridge(system.eventStream, clazz)
override def apply(name: String): NoDepsLogger =
new PekkoLoggerBridge(system.eventStream, name,
classOf[DummyClassForStringSources])
}
+/**
+ * Internal Usage only. Will be removed in Pekko 2.0.0.
+ */
+@InternalApi
class PekkoLoggerBridge(bus: EventStream, logSource: String, logClass:
Class[_]) extends NoDepsLogger {
Review Comment:
Should we add deprecated annotation here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
