He-Pin commented on code in PR #2175: URL: https://github.com/apache/pekko/pull/2175#discussion_r2328614447
########## actor/src/main/scala/org/apache/pekko/dispatch/ThreadPoolBuilder.scala: ########## @@ -76,16 +77,18 @@ trait ExecutorServiceFactoryProvider { } /** - * A small configuration DSL to create ThreadPoolExecutors that can be provided as an ExecutorServiceFactoryProvider to Dispatcher + * INTERNAL API + * + * Configuration object for ThreadPoolExecutor */ +@InternalApi final case class ThreadPoolConfig( allowCorePoolTimeout: Boolean = ThreadPoolConfig.defaultAllowCoreThreadTimeout, corePoolSize: Int = ThreadPoolConfig.defaultCorePoolSize, maxPoolSize: Int = ThreadPoolConfig.defaultMaxPoolSize, threadTimeout: Duration = ThreadPoolConfig.defaultTimeout, queueFactory: ThreadPoolConfig.QueueFactory = ThreadPoolConfig.linkedBlockingQueue(), - rejectionPolicy: RejectedExecutionHandler = ThreadPoolConfig.defaultRejectionPolicy) - extends ExecutorServiceFactoryProvider { Review Comment: Removed `extends ExecutorServiceFactoryProvider` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org