rrwright commented on code in PR #744: URL: https://github.com/apache/pekko-http/pull/744#discussion_r2331434355
########## http-tests/src/test/scala/org/apache/pekko/http/scaladsl/unmarshalling/sse/LineParserSpec.scala: ########## @@ -1,66 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * license agreements; and to You under the Apache License, version 2.0: - * - * https://www.apache.org/licenses/LICENSE-2.0 - * - * This file is part of the Apache Pekko project, which was derived from Akka. - */ - -/* - * Copyright (C) 2009-2022 Lightbend Inc. <https://www.lightbend.com> - */ - -package org.apache.pekko.http -package scaladsl -package unmarshalling -package sse - -import org.apache.pekko -import pekko.stream.scaladsl.{ Sink, Source } -import pekko.util.ByteString -import org.scalatest.matchers.should.Matchers -import org.scalatest.wordspec.AsyncWordSpec - -final class LineParserSpec extends AsyncWordSpec with Matchers with BaseUnmarshallingSpec { Review Comment: git oversight. thank you for catching/questioning. fixed. ########## http/src/main/scala/org/apache/pekko/http/javadsl/settings/ServerSentEventSettings.scala: ########## @@ -42,9 +45,47 @@ abstract class ServerSentEventSettings private[pekko] () { self: ServerSentEvent */ def emitEmptyEvents: Boolean - // --- + /** + * How to handle messages that exceed max-line-size limit. + * Valid options: "fail-stream", "log-and-skip", "truncate", "dead-letter" + */ Review Comment: Added. Looking through code for precedents, it looks like it may also apply to enums, sealed traits, or things. I'm not entirely sure where it's required, but please advise if some were missed or others are unnecessary. (in latest commit) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
