pjfanning commented on code in PR #1162: URL: https://github.com/apache/pekko-connectors/pull/1162#discussion_r2339415220
########## README.md: ########## @@ -19,7 +19,7 @@ To keep up with the latest releases check out [Pekko Connectors releases](https: ## Building From Source -The build commands in the [pekko](https://github.com/apache/pekko?tab=readme-ov-file#building-from-source) repo are also useful here. Java 8 should work well for building from source with this repo. Building the Paradox docs is significatntly harder if you use Java 17 or above. You will need to specify a large number of `--add-opens` settings. +The build commands in the [pekko](https://github.com/apache/pekko?tab=readme-ov-file#building-from-source) repo are also useful here. Java 17 should work well for building from source with the main branch. Pekko 1.x is best built with Java 8. If you build with newer versions of Java, ou will need to specify a number of `--add-opens` settings. Review Comment: ```suggestion The build commands in the [pekko](https://github.com/apache/pekko?tab=readme-ov-file#building-from-source) repo are also useful here. Java 17 should work well for building from source with the main branch. Pekko 1.x is best built with Java 8. If you build with newer versions of Java, you will need to specify a number of `--add-opens` settings. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
