pjfanning commented on code in PR #755:
URL: https://github.com/apache/pekko-http/pull/755#discussion_r2336006325
##########
http2-tests/src/test/scala/org/apache/pekko/http/impl/engine/http2/Http2FrameHpackSupport.scala:
##########
@@ -58,10 +57,9 @@ trait Http2FrameHpackSupport extends
Http2FrameProbeDelegator with Http2FrameSen
val decoder = new Decoder(Http2Protocol.InitialMaxHeaderListSize,
Http2Protocol.InitialMaxHeaderTableSize)
def decodeHeaders(bytes: ByteString): Seq[(String, String)] = {
- val bis = ByteStringInputStream(bytes)
val hs = new VectorBuilder[(String, String)]()
- decoder.decode(bis,
+ decoder.decode(bytes.asInputStream,
Review Comment:
this is test code so I didn't think the close was as important
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
