He-Pin commented on code in PR #776:
URL: https://github.com/apache/pekko-http/pull/776#discussion_r2347275007
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/settings/ConnectionPoolSettings.scala:
##########
@@ -37,7 +36,7 @@ abstract class ConnectionPoolSettings private[pekko] () {
self: ConnectionPoolSe
def getMaxRetries: Int = maxRetries
def getMaxOpenRequests: Int = maxOpenRequests
def getPipeliningLimit: Int = pipeliningLimit
- def getMaxConnectionLifetime: JDuration = maxConnectionLifetime.asJava
+ def getMaxConnectionLifetime: JDuration =
JDuration.ofNanos(maxConnectionLifetime.toNanos)
Review Comment:
if maxConnectionLifetime.isFinate maxConnectionLifetime.toJava else
JDuration.Zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
