pjfanning commented on code in PR #363: URL: https://github.com/apache/pekko-connectors-kafka/pull/363#discussion_r2353131438
########## core/src/main/scala/org/apache/pekko/kafka/scaladsl/SendProducer.scala: ########## @@ -106,7 +106,17 @@ final class SendProducer[K, V] private (val settings: ProducerSettings[K, V], sy } object SendProducer { + + @deprecated("use create method instead", "1.2.0") def apply[K, V](settings: ProducerSettings[K, V])(implicit system: ClassicActorSystemProvider): SendProducer[K, V] = + create(settings) Review Comment: keep this for Scala users - it is more natural for Scala users to use apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org