mdedetrich commented on PR #2244: URL: https://github.com/apache/pekko/pull/2244#issuecomment-3315310692
@He-Pin I added an extra commit for a more performant solution to the `java.lang.Long`/`scala.lang.Long` issue. While it is true that `scala.long.Long` is a supertype of `java.lang.Long`, because `CompletionStage` is invariant it doesn't compile as is so you have to use `asInstanceOf`. The Java `SinkTest` is passing locally without any issues, but ill wait till tomorrow morning (my time) for all the tests to pass so I can approve the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
