Copilot commented on code in PR #2242:
URL: https://github.com/apache/pekko/pull/2242#discussion_r2366576005
##########
actor/src/main/resources/reference.conf:
##########
@@ -492,6 +492,10 @@ pekko {
# --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED
# --add-opens=java.base/java.lang=ALL-UNNAMED
virtualize = off
+
+ # When virtualize = on, you can set the starting id for virtual
threads created by this dispatcher.
+ # -1 to turn off, 0 (default) to start from 0, or any positive number
to start from that number.
+ virtual-thread-start-number = -1
Review Comment:
The default value is set to -1 (no numbering) in the configuration, but the
documentation in the code comments suggests 0 is the default. This
inconsistency should be resolved to avoid confusion.
```suggestion
virtual-thread-start-number = 0
```
##########
actor/src/main/resources/reference.conf:
##########
@@ -569,6 +577,10 @@ pekko {
#jdk.virtualThreadScheduler.minRunnable
#jdk.unparker.maxPoolSize
fallback = "fork-join-executor"
+
+ # When using virtual-thread-executor, you can set the starting number
for virtual threads created by this dispatcher.
+ # -1 to turn off, 0 (default) to start from 0, or any positive number
to start from that number.
+ virtual-thread-start-number = -1
Review Comment:
The default value is set to -1 (no numbering) in the configuration, but the
documentation in the code comments suggests 0 is the default. This
inconsistency should be resolved to avoid confusion.
```suggestion
virtual-thread-start-number = 0
```
##########
actor/src/main/resources/reference.conf:
##########
@@ -623,6 +635,10 @@ pekko {
# --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED
# --add-opens=java.base/java.lang=ALL-UNNAMED
virtualize = off
+
+ # When virtualize = on, you can set the starting number for virtual
threads created by this dispatcher.
+ # -1 to turn off, 0 (default) to start from 0, or any positive number
to start from that number.
Review Comment:
The default value is set to -1 (no numbering) in the configuration, but the
documentation in the code comments suggests 0 is the default. This
inconsistency should be resolved to avoid confusion.
```suggestion
# -1 (default) to turn off, 0 to start from 0, or any positive
number to start from that number.
```
##########
actor/src/main/resources/reference.conf:
##########
@@ -555,6 +559,10 @@ pekko {
# --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED
# --add-opens=java.base/java.lang=ALL-UNNAMED
virtualize = off
+
+ # When virtualize = on, you can set the starting number for virtual
threads created by this dispatcher.
+ # -1 to turn off, 0 (default) to start from 0, or any positive number
to start from that number.
+ virtual-thread-start-number = -1
Review Comment:
The default value is set to -1 (no numbering) in the configuration, but the
documentation in the code comments suggests 0 is the default. This
inconsistency should be resolved to avoid confusion.
```suggestion
virtual-thread-start-number = 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
