He-Pin commented on code in PR #2250:
URL: https://github.com/apache/pekko/pull/2250#discussion_r2368657091


##########
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Sink.scala:
##########
@@ -312,6 +312,19 @@ object Sink {
       if (fanout) new 
FanoutPublisherSink[T](DefaultAttributes.fanoutPublisherSink, 
shape("FanoutPublisherSink"))
       else new PublisherSink[T](DefaultAttributes.publisherSink, 
shape("PublisherSink")))
 
+  /**
+   * A `Sink` that materializes this `Sink` itself as a `Source`.
+   * The returned `Source` is a "live view" onto the `Sink` and only supports 
a single `Subscriber`.

Review Comment:
   The original requirement is similar to implementing a proxy, where one API 
requires a Sink for consumption, and another API requires a Source for data 
provision, connecting them together. However, the current API is just an API, 
and because it hasn't been optimized for the materializer, it introduces 
asynchronous boundaries, but it should be better than before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to