He-Pin commented on code in PR #799:
URL: https://github.com/apache/pekko-http/pull/799#discussion_r2381113711
##########
http-core/src/main/scala/org/apache/pekko/http/impl/engine/parsing/BodyPartParser.scala:
##########
@@ -355,15 +355,23 @@ private[http] object BodyPartParser {
case class UndefinedEndOfLineConfiguration(boundary: String) extends
EndOfLineConfiguration {
override def eol: String = "\r\n"
- private val CR: Byte = 13
- private val LF: Byte = 10
+ private final val CR: Byte = 13
+ private final val LF: Byte = 10
Review Comment:
Can we have a dedicated new class `HttpConstants` to put these bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
