raboof commented on code in PR #803:
URL: https://github.com/apache/pekko-http/pull/803#discussion_r2384390046
##########
http-tests/src/test/scala/org/apache/pekko/http/scaladsl/server/ConnectionTestApp.scala:
##########
@@ -43,10 +43,11 @@ object ConnectionTestApp {
val clientFlow = Http().superPool[Int]()
- val sourceActor = {
+ val sourceQueue = {
// Our superPool expects (HttpRequest, Int) as input
val source =
- Source.actorRef[(HttpRequest, Int)](10000,
OverflowStrategy.dropNew).buffer(20000, OverflowStrategy.fail)
+ Source.queue[(HttpRequest, Int)](10000)
+ .buffer(20000, OverflowStrategy.fail)
Review Comment:
> Would
https://pekko.apache.org/japi/pekko/1.2/org/apache/pekko/stream/OverflowStrategy.html#backpressure()
make sense? OverflowStrategy.dropNew is being removed (already deprecated in
1.x).
TBH I'm not sure what this means in practice here - would that mean 'offer'
would give a return value indicating the backpressure? I think `fail` is
probably a fine choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
