pjfanning commented on code in PR #2274: URL: https://github.com/apache/pekko/pull/2274#discussion_r2399105608
########## CONTRIBUTING.md: ########## @@ -533,7 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following 1. Use `scala.jdk.javaapi.OptionConverters` to translate `Option`s to Java `Optional`s (or vice versa). -1. Use `org.apache.pekko.util.FunctionConverters` to translate Scala Functions to Java Functions (or vice versa). +1. Use `scala.jdk.javapi.FunctionConverters` to translate Scala Functions to Java Functions (or vice versa). Review Comment: actually https://www.scala-lang.org/api/2.13.16/scala/jdk/javaapi/FunctionConverters$.html does exist - this section is about people writing Java APIs and some of the Java APIs are written in Java (but some are in Scala) - so it sort of depends, Java users should use https://www.scala-lang.org/api/2.13.16/scala/jdk/javaapi/FunctionConverters$.html while Scala code should use scala.jdk.FunctionConverters implicits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
