pjfanning commented on code in PR #2300:
URL: https://github.com/apache/pekko/pull/2300#discussion_r2410028160
##########
actor/src/main/scala/org/apache/pekko/util/ByteString.scala:
##########
@@ -590,7 +592,7 @@ object ByteString {
}
override def asInputStream: InputStream =
Review Comment:
This inherits this javadoc:
```
/**
* Return the bytes in this ByteString as an InputStream.
*
* @return the bytes in this ByteString accessible as an InputStream
* @see [[asByteBuffer]]
* @since 1.1.0
*/
```
I think this is ok as is. It doesn't mention anything about the InputStream
implementation which is good because it gives us flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
