pjfanning commented on code in PR #814:
URL: https://github.com/apache/pekko-http/pull/814#discussion_r2399414206
##########
http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/hpack/HeaderDecompression.scala:
##########
@@ -102,7 +103,7 @@ private[http2] final class
HeaderDecompression(masterHeaderParser: HttpHeaderPar
// this is signalled by the decoder when it failed, we want to
react to this by rendering a GOAWAY frame
fail(eventsOut,
new
Http2Compliance.Http2ProtocolException(ErrorCode.COMPRESSION_ERROR,
"Decompression failed."))
- }
+ } finally bis.close()
Review Comment:
changed - the existing code usually formats 1 line `finally` statements like
I did in my first draft but I'm neutral about which is best
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
