pjfanning commented on PR #2365: URL: https://github.com/apache/pekko/pull/2365#issuecomment-3446906711
I had a look at modifying the new code to not throw the NullStateException when the state evaluated as null but the new tests end up with NoSuchElementExceptions instead. I think the options are: * revert this and just keep the existing code and agree that this change is not important * keep this change and mandate the users who rely on 'null' state can modify their code to use something like scala.None or java.lang.Optional.empty() instead. * a significant rewrite of the new code that somehow allows nulls but that allows the new tests to work - this code is not an area of expertise for me so if someone wants to go this route, can they provide a PR? wdyt? @He-Pin @mdedetrich @raboof @jrudolph -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
