He-Pin commented on code in PR #2395:
URL: https://github.com/apache/pekko/pull/2395#discussion_r2464289393
##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -443,13 +447,16 @@ class Serialization(val system: ExtendedActorSystem)
extends Extension {
}
private def warnUnexpectedNonPekkoSerializer(clazz: Class[_], ser:
Serializer): Boolean = {
- if (clazz.getName.startsWith("org.apache.pekko.") &&
!ser.getClass.getName.startsWith("org.apache.pekko.")) {
+ val clazzName = clazz.getName
+ if (clazzName.startsWith(PekkoPackagePrefix) &&
!ser.getClass.getName.startsWith(PekkoPackagePrefix)
+ // no serializers for these in Pekko
+ && !(clazzName.startsWith(PekkoHttpPackagePrefix) ||
clazzName.startsWith(PekkoGrpcPackagePrefix))) {
Review Comment:
I think I can drop these if you like @pjfanning
##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -15,7 +15,6 @@ package org.apache.pekko.serialization
import java.io.NotSerializableException
import java.nio.ByteBuffer
-import java.util.NoSuchElementException
Review Comment:
remove this unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
