mdedetrich commented on PR #2427: URL: https://github.com/apache/pekko/pull/2427#issuecomment-3478402689
> I think you are right but I actually followed the `Flowable` /`Flux`, where both are named `fromArray`, or we can ignore this, because we can treat . > > We can already do that without this method but with an error: > > ``` > method copyArrayToImmutableIndexedSeq in class LowPriorityImplicits2 is deprecated (since 2.13.0): implicit conversions from Array to immutable.IndexedSeq are implemented by copying; use `toIndexedSeq` explicitly if you want to copy, or use the more efficient non-copying ArraySeq.unsafeWrapArray > [error] Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=deprecation, site=org.apache.pekko.stream.scaladsl.FlowOnErrorCompleteSpec, origin=scala.LowPriorityImplicits2.copyArrayToImmutableIndexedSeq, version=2.13.0 > ``` That might be true for `javadsl` but in Scala its idiomatic to have a single `def apply` method with overloaded alternatives. Made a PR, see https://github.com/apache/pekko/pull/2428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
