migesok commented on issue #2026: URL: https://github.com/apache/pekko/issues/2026#issuecomment-3502919525
@pjfanning > [#2434](https://github.com/apache/pekko/pull/2434) broke the tests associated with this change. I guess if users don't mind about the write order then this is ok. It does make me reluctant to consider making the changes that you made the default in a future release. Opt in is fine. I investigated it for a bit: - the spec failing was written by me - `AsyncWriteJournalResponseOrderSpec.return write responses in completion order if global response order is disabled` - there is no problem with `AsyncWriteJournal` itself but with my test case - basically I accidentally relied on an ordering guarantee which wasn't really there. Even though I complete `asyncWriteMessages` promises in some particular order, `AsyncWriteJournal` sends out messages in an `onComplete` cb scheduled on the actor dispatcher, yielding random message order. - but it's not a big deal for the production, non-test, code because particular order is not important there. " guess if users don't mind about the write order then this is ok" - the only users there are Akka Persistence and Akka Persistence Typed internals and neither of those care about global ordering, AFAIK. At least the dispatcher change doesn't affect this anyhow. I have a prototype for fixing AsyncWriteJournalResponseOrderSpec which seems to work but I need a bit more time to polish it. Do you mind if I provide the changes needed next week? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
