pjfanning commented on PR #2486: URL: https://github.com/apache/pekko/pull/2486#issuecomment-3523033602
> > Would it be acceptable to not put this on ActorSystem but create a factory method like `ActorSystem.createWithBlockingClose()` or `ActorSystem.apply(withBlockingClose: Boolean = false)`? > > Well I would still have to put it on `ActorSystem` otherwise `AutoCloseable` won't work, but I can make the blocking behaviour configurable (alternately it can go in `reference.conf` though given that `close` should block by default)> > > I think the point is, if you are going to use `close()` and don't want it to block, at that point you are already rolling your own resource cleaning mechanism at which point `close()` + `AutoCloseable` is kind of pointless. There are also already methods that do close in an async manner (thats what `.terminate()` does). A config option to decide on whether the close is blocking alongside a config to control the timeout for blocking seems ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
