The GitHub Actions job "Pull Requests" on pekko.git/reseq-test has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 1cbd25df85c62f527608cf2398d877daf491ef1a / Mikhail Sokolov <[email protected]> Fix AsyncWriteJournalResponseOrderSpec with global dispatcher (#2477) * Fix AsyncWriteJournalResponseOrderSpec with global dispatcher This fixes a random test failure when the global dispatcher used as a persistence plugin dispatcher. This change should unblock https://github.com/apache/pekko/pull/2434 Also adjusted wording changes for write-response-global-order from https://github.com/apache/pekko/pull/2437 The test relied on an ordering guarantee which wasn't really there. Even though asyncWriteMessages promises were completed in some particular order, AsyncWriteJournal sent out messages in an onComplete callback scheduled on the actor dispatcher, yielding random message order. The test failure shouldn't be a problem for production, non-test, Pekko code, because nothing there relies on write response ordering guarantees between independent persistent actors. And for an individual persistent actor writes - the persistent actor implementation internals handle ordering there correctly regardless of the plugin response ordering. * FIXUP Report URL: https://github.com/apache/pekko/actions/runs/19309854320 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
