pjfanning commented on code in PR #2492:
URL: https://github.com/apache/pekko/pull/2492#discussion_r2524015481


##########
actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/OnMessageIntroTest.java:
##########
@@ -137,26 +137,19 @@ public Behavior<RoomCommand> onMessage(RoomCommand msg) 
throws UnsupportedEncodi
          *     return onPublishSessionMessage(psm);
          *   }
          *
-         * Java 17 onward: JEP 406 (https://openjdk.org/jeps/406) =>
+         * Java 21 onward: JEP 441 (https://openjdk.org/jeps/441 =>

Review Comment:
   * our existing docs have stuff about this but say Java 21 is when it was 
implemented - 441 is a Java 21 JEP
   * there were some preview JEPs before that but my experience is that orgs 
are reluctant to set the preview flag when running Java
   * it just is easier to say Java 21 than to give a long spiel about when 
which preview JEP became available when
   * anyone who has enabled preview on their JVM will just know anyway - no 
need to confuse everyone else
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to