mdedetrich commented on PR #546: URL: https://github.com/apache/pekko-management/pull/546#issuecomment-3546439355
So I have just added a regressing test, but I am still slightly apprehensive in merging as the comment at https://github.com/apache/pekko-management/blob/606f90024f7e8a57385c4f170cc4c897714dc0cc/lease-kubernetes/src/main/scala/org/apache/pekko/coordination/lease/kubernetes/internal/AbstractKubernetesApiImpl.scala#L172-L174 implies there may be some bottleneck/performance considerations in how often this API method is called. I mean if the API is called every now and then, even it being blocking wouldn't be a real issue in production so the comment seems to imply that the API is called frequently??? If so then I should implement a cache (but in doing so I need to know how long it is before a token that is rotated out expires). @raboof @laurens-gross-mw maybe you have some context here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
